-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate client and server to improve candidate experience #2
Open
joe-bruce
wants to merge
25
commits into
kronick:master
Choose a base branch
from
plangrid:separate-client-server
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include node modules to guarantee package availability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Candidates have struggled to make heads or tails of this challenge, partly, because the client-server communication is simulated with an in-browser, in-memory "server". To try to improve that experience and make the problem more accessible, I've separated the server from the client and moved it to a local express server with similar behavior (simulated lag, simulated network failures).
This has the effect of making the Network tools in the browser useful for investigation and debugging. It also makes it easier to keep candidates from attempting to investigate the server code, which is not part of the exercise.
There are a few notable changes, however:
add
route no longer returns the points in the response payload; a second request has to be made to refresh the points. This slows down even the "ideal", no-space-station implementation. A good candidate, however, has an excellent opportunity to make it better.points
route is no long called on interval. It is only called in response to known mutations on the server. This doesn't fit the scenario described (because astronauts are supposed to be drawing too) but still fits what we're actually asking the candidate to do/fix.I went through it myself, both with id and request ordering solutions and I think I've preserved the main concepts while making standard browser tools more useful. I'd love thoughts, corrections, clean-ups, ideas.